From: Jonathan Nieder <jrnieder@gmail.com>
Date: Thu, 20 Jul 2017 23:30:51 GMT
Subject: Re: [PATCH 21/28] commit_packed_refs(): use a staging file separate from the lockfile
Message-ID: <20170720233051.GB159617@aiede.mtv.corp.google.com>
In-Reply-To: <xmqqy3riiu0f.fsf@gitster.mtv.corp.google.com>

Junio C Hamano wrote:
> Michael Haggerty <mhagger@alum.mit.edu> writes:

>> We will want to be able to hold the lockfile for `packed-refs` even
>> after we have activated the new values. So use a separate tempfile,
>> `packed-refs.new`, as a place to stage the new contents of the
>> `packed-refs` file. For now this is all done within
>> `commit_packed_refs()`, but that will change shortly.
>>
>> Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
>> ---
>
> The layout created by "contrib/workdir/git-new-workdir" will be
> broken by this line of change.  "git worktree" is supposed to know
> that refs/packed-refs is a shared thing and lives in common-dir,
> so it shouldn't be affected.
>
> Do we care about the ancient layout that used symlinks to emulate
> the more modern worktree one?

I think we do care.  In the context of people's changing workflows,
"git worktree" is a relatively new tool.  Breaking the older
git-new-workdir (and tools that emulate it) would affect a large
number of users that don't necessarily know how to clean up the
result.

Thanks,
Jonathan