From: Jonathan Tan <jonathantanmy@google.com>
Date: Wed, 12 Jul 2017 21:19:05 GMT
Subject: Re: [PATCH 1/3] trailers: create struct trailer_opts
Message-ID: <20170712141905.14c812b4@twelve2.svl.corp.google.com>
In-Reply-To: <20170712134646.17179-2-bonzini@gnu.org>

On Wed, 12 Jul 2017 15:46:44 +0200
Paolo Bonzini <bonzini@gnu.org> wrote:

> -static void print_all(FILE *outfile, struct list_head *head, int trim_empty)
> +static void print_all(FILE *outfile, struct list_head *head,
> +		      struct trailer_opts *opts)

This can be "const struct trailer_opts *", I think. (Same for the other
functions in this patch.)

> +struct trailer_opts {
> +	int in_place;
> +	int trim_empty;
> +};

I was going to suggest that you make these "unsigned in_place : 1" etc.,
but I think OPT_BOOL doesn't support those. (And OPT_BIT is probably not
worth it.)