From: Jeff King Date: Tue, 11 Jul 2017 10:47:56 GMT Subject: Re: [PATCH 0/7] tag: more fine-grained pager-configuration Message-ID: <20170711104755.4z5exp43lvwbb5hq@sigill.intra.peff.net> In-Reply-To: On Mon, Jul 10, 2017 at 03:42:14PM -0700, Junio C Hamano wrote: > > A review would be much appreciated. Comments on the way I > > structured the series would be just as welcome as ones on the > > final result. > > I see you CC'ed Peff who's passionate in this area, so these patches > are in good hands already ;-) I briefly skimmed your patches myself, > and did not spot anything glaringly wrong. Heh, I don't think of "paging tag output" as one of my passions, but you may be right. :) I left a few comments on the code and direction, but I agree that overall it looks pretty good. And I'm very impressed with the attention to detail for a first-time contributor. -Peff