From: tboegi@web.de Date: Sat, 01 Jul 2017 12:50:57 GMT Subject: [PATCH v2 1/2] Check DB_ENVIRONMENT using is_directory() Message-ID: <20170701125057.16169-1-tboegi@web.de> In-Reply-To: <20170628162958.519-1-tboegi@web.de> From: Torsten Bögershausen In setup.c is_git_directory() checks a Git directory using access(X_OK). This does not check, if path is a file or a directory. Check path with is_directory() instead. --- After all the discussions (and lots of tests) I found that this patch works for my setup. All in all could the error reporting be improvved for is_git_directory(), as there may be "access denied", or "not a directory" or others, but that is for another day. setup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.c b/setup.c index 358fbc2..5a7ee2e 100644 --- a/setup.c +++ b/setup.c @@ -321,7 +321,7 @@ int is_git_directory(const char *suspect) /* Check non-worktree-related signatures */ if (getenv(DB_ENVIRONMENT)) { - if (access(getenv(DB_ENVIRONMENT), X_OK)) + if (!is_directory(getenv(DB_ENVIRONMENT))) goto done; } else { -- 2.10.0