From: Jonathan Tan Date: Mon, 26 Jun 2017 16:55:30 GMT Subject: Re: What's cooking in git.git (Jun 2017, #07; Sat, 24) Message-ID: <20170626095530.49c82646@twelve2.svl.corp.google.com> In-Reply-To: On Sat, 24 Jun 2017 16:25:13 -0700 Junio C Hamano wrote: > * jt/unify-object-info (2017-06-21) 8 commits > - sha1_file: refactor has_sha1_file_with_flags > - sha1_file: do not access pack if unneeded > - sha1_file: improve sha1_object_info_extended > - sha1_file: refactor read_object > - sha1_file: move delta base cache code up > - sha1_file: rename LOOKUP_REPLACE_OBJECT > - sha1_file: rename LOOKUP_UNKNOWN_OBJECT > - sha1_file: teach packed_object_info about typename > > Code clean-ups. > > Looked sensible to me. Any further comments? > cf. <20170624124522.p2dnwdah75e4ngya@sigill.intra.peff.net> In a reply that I just sent out [1], I suggested "sha1_file: support more flags in object info query" to replace "sha1_file: improve sha1_object_info_extended" (the 6th patch from the bottom). If you are OK with that commit message title, and if you prefer not to make the change locally yourself, I can send out a reroll with the updated commit message title. [1] https://public-inbox.org/git/CAGf8dgJ8C0chOxZo5CPt56225XGBgrjaGy8HDAST+0-USfW6mA@mail.gmail.com/