From: Jeff King Date: Sat, 24 Jun 2017 14:23:01 GMT Subject: Re: [PATCH v5 0/5] convert: add "status=delayed" to filter process protocol Message-ID: <20170624142301.c5jl7xxf4ici3cug@sigill.intra.peff.net> In-Reply-To: <20170601082203.50397-1-larsxschneider@gmail.com> On Thu, Jun 01, 2017 at 10:21:58AM +0200, Lars Schneider wrote: > here is the 5th iteration of my "status delayed" topic. Patch 1 to 3 are > minor t0021 test adjustments and haven't been changed since v3. Patch 4 > is a minor "extract method" refactoring in convert. Patch 5 is the new > feature. Yeah, patches 1-4 were pretty straightforward and obvious. I just left some comments after a detailed read-through of patch 5. Overall the direction looks good. I had a few minor comments on the code, but I think with those addressed it will probably be ready for 'next'. Note that I'll be offline all next week, so don't expect a timely review on the next iteration (unlike this not-so-timely one ;) ). -Peff