From: Jeff King Date: Fri, 23 Jun 2017 19:51:45 GMT Subject: Re: [PATCH v2 27/29] commit_packed_refs(): remove call to `packed_refs_unlock()` Message-ID: <20170623195144.jsha7bdm4r2d6rrg@sigill.intra.peff.net> In-Reply-To: <35e859b7a4776bf5818cfbf12016c61fa2be04b8.1498200513.git.mhagger@alum.mit.edu> On Fri, Jun 23, 2017 at 09:01:45AM +0200, Michael Haggerty wrote: > Instead, change the callers of `commit_packed_refs()` to call > `packed_refs_unlock()`. Why? I can guess that the reason is probably "because we're going to add a new caller that doesn't want to do that", but it's nice to hear even that. Those kinds of clues help make a more coherent narrative when you're reading through 29 refactoring patches. ;) -Peff