From: Jeff King <peff@peff.net>
Date: Mon, 19 Jun 2017 09:16:54 GMT
Subject: Re: [PATCH v2 0/2] Fix a refname trimming problem in `log --bisect`
Message-ID: <20170619091654.vb7krwcmw2y22v7m@sigill.intra.peff.net>
In-Reply-To: <cover.1497792827.git.mhagger@alum.mit.edu>

On Sun, Jun 18, 2017 at 03:39:40PM +0200, Michael Haggerty wrote:

> This is v2 of these patches. Thanks to Peff and Junio for their
> feedback about v1 [1].
> 
> Changes since v1:
> 
> * Added a test and tweaked the commit message of the first patch.

Thanks, both changes look good to me.

> As before, the second patch is optional. If it is omitted, it might
> flush out any other bugs like this one in client code. If it is
> included, regressions are less likely, but we won't learn about other
> misuses of the API. I have no strong opinion either way.

My feeling is still slightly towards "don't include", but I also don't
have a strong opinion.

-Peff