From: Jeff King <peff@peff.net>
Date: Fri, 16 Jun 2017 12:14:23 GMT
Subject: Re: [PATCH 2/3] wt-status: add optional stash status information
Message-ID: <20170616121423.smdtmcmbktuit2qb@sigill.intra.peff.net>
In-Reply-To: <20170616043050.29192-3-liambeguin@gmail.com>

On Fri, Jun 16, 2017 at 12:30:49AM -0400, Liam Beguin wrote:

> @@ -1642,6 +1664,8 @@ static void wt_longstatus_print(struct wt_status *s)
>  		} else
>  			printf(_("nothing to commit, working tree clean\n"));
>  	}
> +	if (!git_config_get_bool("status.showStash", &show_stash) && show_stash)
> +		wt_longstatus_print_stash_summary(s);
>  }

This feels like a funny place to look up the config. How would you
override it if were to have a "--no-stash" command line option?

The usual flow is for the caller to examine the config and set up fields
in the wt_status object, which are then respected here in the low-level
code.

So I think you probably want to handle this in git_status_config() along
with other similar variables (like "status.branch").

I don't personally insist on actually adding "--no-stash" or similar to
override it from the command line (there is always "git -c
status.showStash=false" in a pinch). But I have seen other reviewers
(including the maintainer) ask for that in the past, so you may want to
anticipate it.

-Peff