From: Jeff King Date: Fri, 02 Jun 2017 20:17:33 GMT Subject: Re: [PATCH 0/3] Use skip_prefix() in handle_revision_{,pseudo_}opt() Message-ID: <20170602201733.r277dubonpyuavqv@sigill.intra.peff.net> In-Reply-To: <20170602191010.16834-1-szeder.dev@gmail.com> On Fri, Jun 02, 2017 at 09:10:07PM +0200, SZEDER Gábor wrote: > While at it, the first one fixes a minor bug, which allowed e.g. 'git > log --no-min-parents-foobarbaz' to succeed. > > The other two are fairly straightforward starts_with() -> > skip_prefix() conversions. These all look fine to me. It would be nice to address the extra cases I mentioned on top, but even without that this is a strict improvement. -Peff