From: Brandon Williams Date: Wed, 31 May 2017 21:43:55 GMT Subject: [PATCH 09/31] setup: add comment indicating a hack Message-ID: <20170531214417.38857-10-bmwill@google.com> In-Reply-To: <20170531214417.38857-1-bmwill@google.com> 'GIT_TOPLEVEL_PREFIX_ENVIRONMENT' was added in (b58a68c1c setup: allow for prefix to be passed to git commands) to aid in fixing a bug where 'ls-files' and 'grep' were not able to properly recurse when called from within a subdirectory. Add a 'NEEDSWORK' comment indicating that this envvar should be removed once 'ls-files' and 'grep' can recurse in-process. Signed-off-by: Brandon Williams --- setup.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/setup.c b/setup.c index dba3abd00..c3d21345d 100644 --- a/setup.c +++ b/setup.c @@ -1057,6 +1057,12 @@ const char *setup_git_directory_gently(int *nongit_ok) die("BUG: unhandled setup_git_directory_1() result"); } + /* + * NEEDSWORK: This was a hack in order to get ls-files and grep to have + * properly formated output when recursing submodules. Once ls-files + * and grep have been changed to perform this recursing in-process this + * needs to be removed. + */ env_prefix = getenv(GIT_TOPLEVEL_PREFIX_ENVIRONMENT); if (env_prefix) prefix = env_prefix; -- 2.13.0.506.g27d5fe0cd-goog