From: Jeff King <peff@peff.net>
Date: Tue, 30 May 2017 06:05:55 GMT
Subject: Re: [PATCH 8/8] t0012: test "-h" with builtins
Message-ID: <20170530060555.ponbsyp4agdo4yau@sigill.intra.peff.net>
In-Reply-To: <xmqqwp8yc255.fsf@gitster.mtv.corp.google.com>

On Tue, May 30, 2017 at 03:03:18PM +0900, Junio C Hamano wrote:

> > +test_expect_success 'generate builtin list' '
> > +	git --list-builtins >builtins
> > +'
> > +
> > +while read builtin
> > +do
> > +	test_expect_success "$builtin can handle -h" '
> > +		test_expect_code 129 git $builtin -h >output 2>&1 &&
> > +		test_i18ngrep usage output
> > +	'
> > +done <builtins
> > +
> 
> These still seem to need further tweaks?
> 
>     diff-files
>     diff-index
>     diff-tree
>     rev-list

How so? They pass the test for me, and the output for a manual run looks
sane.

-Peff