From: Jeff King Date: Fri, 26 May 2017 19:06:41 GMT Subject: [PATCH 1/6] t4208: add check for ":/" without matching file Message-ID: <20170526190641.s4pwrb4ty7zfdmcd@sigill.intra.peff.net> In-Reply-To: <20170526190607.jr44oygs6mzm3q6e@sigill.intra.peff.net> The DWIM magic in check_filename() doesn't just recognize ":/". It actually makes sure that the file it points to exists. t4208 checks only the case where the path is present, not the opposite. Since the next patches will be touching this area, let's add a test to make sure it continues working. Signed-off-by: Jeff King --- t/t4208-log-magic-pathspec.sh | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/t/t4208-log-magic-pathspec.sh b/t/t4208-log-magic-pathspec.sh index 001343e2f..70bc64100 100755 --- a/t/t4208-log-magic-pathspec.sh +++ b/t/t4208-log-magic-pathspec.sh @@ -29,6 +29,12 @@ test_expect_success '"git log -- :/a" should not be ambiguous' ' git log -- :/a ' +# This differs from the ":/a" check above in that :/in looks like a pathspec, +# but doesn't match an actual file. +test_expect_success '"git log :/in" should not be ambiguous' ' + git log :/in +' + test_expect_success '"git log :" should be ambiguous' ' test_must_fail git log : 2>error && test_i18ngrep ambiguous error -- 2.13.0.496.ge44ba89db