From: Jeff King <peff@peff.net>
Date: Mon, 22 May 2017 19:53:35 GMT
Subject: Re: [PATCH v3] ref-filter: trim end whitespace in subject
Message-ID: <20170522195334.eoj4u4nxupyl6dho@sigill.intra.peff.net>
In-Reply-To: <777c63ed-c1e3-8efd-48cd-91ac2a841631@kdbg.org>

On Mon, May 22, 2017 at 09:47:59PM +0200, Johannes Sixt wrote:

> Am 22.05.2017 um 19:10 schrieb DOAN Tran Cong Danh:
> > diff --git a/t/t3203-branch-output.sh b/t/t3203-branch-output.sh
> > index 5778c0afe..fa4441868 100755
> > --- a/t/t3203-branch-output.sh
> > +++ b/t/t3203-branch-output.sh
> > @@ -13,7 +13,8 @@ test_expect_success 'make commits' '
> >   test_expect_success 'make branches' '
> >   	git branch branch-one &&
> > -	git branch branch-two HEAD^
> > +	git branch branch-two $(printf "%s\r\n" one " " line3_long line4 |
> > +	     git commit-tree HEAD:)
> >   '
> >   test_expect_success 'make remote branches' '
> > 
> 
> This updated test shows nothing, I am afraid: If I apply only this change
> without the rest of the patch, then all test in t3203 still pass. And I do
> not see how the code change could make any difference at all. What am I
> missing?

It does for me here on Linux; I wonder if the CRs are being eaten by the
shell expansion.

-Peff