From: Jeff King <peff@peff.net>
Date: Wed, 17 May 2017 12:42:56 GMT
Subject: Re: [PATCH 01/23] t3600: clean up permissions test properly
Message-ID: <20170517124255.62hdqwvcvfy2tdr7@sigill.intra.peff.net>
In-Reply-To: <bb244c72ec6e6ab56171d82f7379a75c4eb5481f.1495014840.git.mhagger@alum.mit.edu>

On Wed, May 17, 2017 at 02:05:24PM +0200, Michael Haggerty wrote:

> The test of failing `git rm -f` removes the write permissions on the
> test directory, but fails to restore them if the test fails. This
> means that the test temporary directory cannot be cleaned up, which
> means that subsequent attempts to run the test fail mysteriously.
> 
> Instead, do the cleanup in a `test_must_fail` block so that it can't
> be skipped.

This should be `test_when_finished` in the final paragraph, right?

The patch itself looks obviously fine.

-Peff