From: Jeff King Date: Sun, 14 May 2017 04:06:00 GMT Subject: Re: [PATCH 18/19] diff: buffer all output if asked to Message-ID: <20170514040559.uvs6c2dnd6aelrln@sigill.intra.peff.net> In-Reply-To: <20170514040117.25865-19-sbeller@google.com> On Sat, May 13, 2017 at 09:01:16PM -0700, Stefan Beller wrote: > + for (i = 0; i < o->line_buffer_nr; i++); > + free((void*)o->line_buffer[i].line); I haven't looked at the patches yet, but this ";" on the for line is almost certainly a typo (gcc catches it due to the misleading indentation of the next line). -Peff