From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Wed, 03 May 2017 23:41:21 GMT
Subject: Re: [PATCH v2 02/53] Clean up outstanding object_id transforms.
Message-ID: <20170503234121.tkb5l2qgyilff4eq@genre.crustytoothpaste.net>
In-Reply-To: <20170502180514.GC181268@google.com>

On Tue, May 02, 2017 at 11:05:14AM -0700, Brandon Williams wrote:
> On 05/01, brian m. carlson wrote:
> > -	if (!logobj && commit_reflog->recno >= 0 && is_null_sha1(reflog->ooid.hash)) {
> > +	if (!logobj && commit_reflog->recno >= 0 && is_null_oid(&reflog->ooid)) {
> 
> Not relevant to this series but I was confused for a second seeing
> 'ooid' as I have no clue what that means :)

These were originally nsha1 and osha1, now noid and ooid.  They are,
respectively, the new and old object IDs.  We've used those in various
places around the codebase.
-- 
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | https://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: https://keybase.io/bk2204