From: Brandon Williams <bmwill@google.com>
Date: Thu, 20 Apr 2017 22:22:09 GMT
Subject: Re: [PATCH v3 01/18] grep: amend submodule recursion test in preparation for rx engine testing
Message-ID: <20170420222209.GK142567@google.com>
In-Reply-To: <20170420212345.7408-2-avarab@gmail.com>

On 04/20, Ævar Arnfjörð Bjarmason wrote:
> Amend the submodule recursion test added in commit 0281e487fd ("grep:
> optionally recurse into submodules", 2016-12-16) to prepare it for
> subsequent tests of whether it passes along the grep.patternType to
> the submodule greps.
> 
> This is just the result of searching & replacing:
> 
>     foobar -> (1|2)d(3|4)
>     foo    -> (1|2)
>     bar    -> (3|4)
> 
> Currently there's no tests for whether e.g. -P or -E is correctly
> passed along, tests for that will be added in a follow-up change, but
> first add content to the tests which will match differently under
> different regex engines.
> 
> Reuse the pattern established in an earlier commit of mine in this
> series ("log: add exhaustive tests for pattern style options &
> config", 2017-04-07). The pattern "(.|.)[\d]" will match this content
> differently under fixed/basic/extended & perl.
> 
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>

Looks good.

-- 
Brandon Williams