From: Jeff King Date: Wed, 19 Apr 2017 21:24:23 GMT Subject: Re: [RFC PATCH] parse-options: disallow double-negations of options starting with no- Message-ID: <20170419212423.i6jnu3q2npnbq2gz@sigill.intra.peff.net> In-Reply-To: On Wed, Apr 19, 2017 at 02:22:47PM -0700, Jacob Keller wrote: > > I think the breakage in that case would be caused by "--no-stage" taking > > over "--stage" as well. And your patch doesn't change that; it happened > > already in 2012. > > > > Your patch only affects the --no-no- form, which I think we would never > > want. I don't think it needs callers to trigger it explicitly. > > Right, I was just thinking in the weird cause were we *do* have a > "no-option" that does want the "no-no-option" to negate it. Maybe this > isn't ever a thing and we don't need to worry at all..? Yeah, my assumption is that we don't need to worry about that case. -Peff