From: Brandon Williams <bmwill@google.com>
Date: Wed, 19 Apr 2017 15:56:59 GMT
Subject: Re: [PATCH v5 02/11] t0061: run_command executes scripts without a #! line
Message-ID: <20170419155659.GA132229@google.com>
In-Reply-To: <9c562827-78f5-ab8f-bf04-5f403672a32d@kdbg.org>

On 04/19, Johannes Sixt wrote:
> Am 19.04.2017 um 07:43 schrieb Johannes Sixt:
> >Am 19.04.2017 um 01:17 schrieb Brandon Williams:
> >>Add a test to 't0061-run-command.sh' to ensure that run_command can
> >>continue to execute scripts which don't include a '#!' line.
> >
> >Why is this necessary? I am pretty certain that our emulation layer on
> >Windows can only run scripts with a shbang line.

Out of curiosity how did you have t5550 passing on windows then?  Since
the first patch in this series fixes a that test which doesn't have a
'#!' line.

> 
> Nevermind. It is a compatibility feature: People may have written
> their hooks and scripts without #!, and these must continue to work
> where they worked before.
> 
> Please protect the new test with !MINGW.

Will do.

> 
> Thanks,
> -- Hannes
> 

-- 
Brandon Williams