From: Eric Wong <e@80x24.org>
Date: Fri, 14 Apr 2017 19:38:34 GMT
Subject: Re: [PATCH v3 06/10] run-command: don't die in child when duping /dev/null
Message-ID: <20170414193833.GA5290@starla>
In-Reply-To: <20170414165902.174167-7-bmwill@google.com>

Brandon Williams <bmwill@google.com> wrote:
> +	if (cmd->no_stdin || cmd->no_stdout || cmd->no_stderr) {
> +		null_fd = open("/dev/null", O_RDWR | O_CLOEXEC | O_NONBLOCK);

O_NONBLOCK?  This was in my original patch, too :x
Wow, I wonder what I was smoking that day...