From: Eric Wong <e@80x24.org>
Date: Fri, 14 Apr 2017 05:26:24 GMT
Subject: Re: [PATCH 7/6] run-command: block signals between fork and execve
Message-ID: <20170414052624.GA815@starla>
In-Reply-To: <20170414024202.GA27281@google.com>

Brandon Williams <bmwill@google.com> wrote:
> On 04/13, Eric Wong wrote:
> > @@ -277,6 +278,8 @@ static void child_err_spew(struct child_process *cmd, struct child_err *cerr)
> >  		error_errno("exec '%s': cd to '%s' failed",
> >  			    cmd->argv[0], cmd->dir);
> >  		break;
> > +	case CHILD_ERR_SIGPROCMASK:
> > +		error_errno("sigprocmask failed restoring signals");
> 
> missing a break statement here I'll add it in, in the re-roll.

Good catch, thanks!

> >  	case CHILD_ERR_ENOENT:
> >  		error_errno("cannot run %s", cmd->argv[0]);
> >  		break;