From: Brandon Williams <bmwill@google.com>
Date: Thu, 13 Apr 2017 21:35:46 GMT
Subject: Re: [PATCH v2 1/6] t5550: use write_script to generate post-update hook
Message-ID: <20170413213546.GA115420@google.com>
In-Reply-To: <20170413205947.GA32659@starla>

On 04/13, Eric Wong wrote:
> Jonathan Nieder <jrnieder@gmail.com> wrote:
> > Brandon Williams wrote:
> > > The post-update hooks created in t5550-http-fetch-dumb.sh is missing the
> > > "!#/bin/sh" line which can cause issues with portability.  Instead
> > > create the hook using the 'write_script' function which includes the
> > > proper "#!" line.
> 
> > This would allow later patches to regress a previously supported
> > behavior.
> > 
> > I agree that it's silly to test that behavior as a side-effect of this
> > unrelated test, but I don't think we want to lose the test coverage.
> 
> I was about to write something similar about this regression.
> The new execve-using code should handle ENOEXEC as execvpe does
> and probably a new test for it needs to be written.

Would it be enough to upon seeing a failed exec call and ENOEXEC to
retry a single time, invoking the shell to attempt to interpret the
command?

-- 
Brandon Williams