From: Jeff King <peff@peff.net>
Date: Tue, 11 Apr 2017 10:53:13 GMT
Subject: Re: [PATCH 10/12] grep: change the internal PCRE macro names to be PCRE1
Message-ID: <20170411105312.5h6gc35lhxvz4ro2@sigill.intra.peff.net>
In-Reply-To: <CACBZZX7gmmTm6qU-6sviRQ3znwkOXG6999C6SDD_oJe6pqdTWw@mail.gmail.com>

On Tue, Apr 11, 2017 at 12:51:09PM +0200, Ævar Arnfjörð Bjarmason wrote:

> > Yeah, I think it's nice to keep the build-time knobs compatible. In the
> > long run I assume we'll want to add a USE_LIBPCRE1 flag and USE_LIBPCRE
> > just becomes a synonym for it (in fact, we could do that in this
> > commit).
> 
> I could just add that. Hints for how to do that without entirely
> copy/pasting the "ifdef USE_LIBPCRE" in the Makefile welcome. The
> Makefile syntax doesn't support some form of "ifdef X || ifdef Y"
> AFAICT, so it looks like I'll need to copy those lines...

Maybe:

  USE_LIBPCRE1 ?= $(USE_LIBPCRE)
  ifdef USE_LIBPCRE1
  ...
  endif

-Peff