From: Brandon Williams <bmwill@google.com>
Date: Fri, 07 Apr 2017 16:53:14 GMT
Subject: Re: problem with backslash in directory name
Message-ID: <20170407165314.GB142670@google.com>
In-Reply-To: <20170407063057.yjbqavu4uiipslpc@sigill.intra.peff.net>

On 04/07, Jeff King wrote:
> On Fri, Apr 07, 2017 at 08:12:49AM +0200, Joachim Durchholz wrote:
> 
> > So... something inside "git submodule add" is replacing the \b with a
> > backspace control code.
> > [...]
> > Whatever that "something" is, it is not doing shell expansion, otherwise it
> > would have started an interactive calculator session.
> 
> Probably it's "read" which does backslash expansion, but nothing else.
> Just grepping git-submodule.sh, some of the "read" calls should probably
> be "read -r" (I also don't know how some of those loops would cope with
> a submodule name that needed quoting).

So I blindly converted all "read" calls to "read -r" and tested against
the case Joachim ran into and it seems to solve the issues.  All test
still pass too (though that may not mean too much).

-- 
Brandon Williams