From: Franke, Knut <knut.franke@atos.net>
Date: Wed, 05 Apr 2017 15:58:27 GMT
Subject: Re: [PATCH 4/7] Handle missing HTTP_CONNECTCODE in curl < 7.10.7
Message-ID: <20170405155827.GE6493@science-computing.de>
In-Reply-To: <CACBZZX4OVy0QOnPLYNY0pptvno+OJ-c6=sRtVWcT+40aaEGY2w@mail.gmail.com>

On 2017-04-05 15:50, Ævar Arnfjörð Bjarmason wrote:
> This effectively disables that code & this later check:
> 
> +               if (results->http_connectcode == 407)
> +                       credential_reject(&proxy_auth);
> 
> What's the impact of not taking that branch when the proxy returns a 407?

We might be storing incorrect proxy credentials via the credential helper. If we can't get the
proxy's connect code, we should probably invalidate proxy credentials whenever http_code indicates
failure, since that's the only effect we'll see of a mistyped proxy password.