From: Jeff King <peff@peff.net>
Date: Thu, 30 Mar 2017 03:12:32 GMT
Subject: Re: [PATCH 2/3] column: allow for custom printf
Message-ID: <20170330031232.cac2av5v5mk5bz7e@sigill.intra.peff.net>
In-Reply-To: <20170330014238.30032-3-sbeller@google.com>

On Wed, Mar 29, 2017 at 06:42:37PM -0700, Stefan Beller wrote:

> Signed-off-by: Stefan Beller <sbeller@google.com>

No justification?

I assume it will be used in a future patch.

> diff --git a/column.h b/column.h
> index 0a61917fa7..c44a1525a9 100644
> --- a/column.h
> +++ b/column.h
> @@ -24,6 +24,9 @@ struct column_options {
>  	int padding;
>  	const char *indent;
>  	const char *nl;
> +
> +	/* when non-NULL, use this printing function, fallback to printf */
> +	int (*_printf)(const char *__format, ...);
>  };

Avoid names with leading underscores. They're reserved by the C
standard.

I wonder if gcc is smart enough to let us mark this function pointer
with a "format" attribute so we can get compile-time checking of the
format string.

-Peff