From: Jonathan Nieder <jrnieder@gmail.com>
Date: Wed, 29 Mar 2017 23:13:09 GMT
Subject: Re: [PATCH 2/2] submodule.c: correctly handle nested submodules in is_submodule_modified
Message-ID: <20170329231308.GZ31294@aiede.mtv.corp.google.com>
In-Reply-To: <20170329222616.11077-3-sbeller@google.com>

Stefan Beller wrote:

> This bug fix also affects the default output (non-short, non-porcelain)
> of git-status, which is not tested here.

Do you have an example?  (In just the commit message would be fine, in
tests would be even better.)

> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
>  Documentation/git-status.txt |  2 ++
>  submodule.c                  | 21 +++++++++++++++++++--
>  t/t3600-rm.sh                |  2 +-
>  t/t7506-status-submodule.sh  |  4 ++--
>  4 files changed, 24 insertions(+), 5 deletions(-)

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

but I would be a lot more comfortable after looking at the change to
"git status" output.  (E.g. a test demonstrating it can happen in a
followup change if that's simpler.)

Thanks for your patient work on this.