From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Wed, 29 Mar 2017 22:28:51 GMT
Subject: Re: [PATCH v2 16/21] Make sha1_array_append take a struct object_id *
Message-ID: <20170329222851.zjdr5hoxjr5wjs7k@genre.crustytoothpaste.net>
In-Reply-To: <xmqqvaqsazec.fsf@gitster.mtv.corp.google.com>

On Wed, Mar 29, 2017 at 08:14:19AM -0700, Junio C Hamano wrote:
> This change is about dropping the need for ".hash", and I think a
> faithful, boring and mechanical conversion that tries to preserve
> the intent of the original author would be more appropriate.  It is
> entirely possible that some places where the original said E2[E3]
> were easier to understand if it were *(E2 + E3), thus we may want to
> further rewrite such a place to (E2 + E3) instead of &E2[E3] after
> the mechanical conversion.

You've convinced me that &E2[E3] is a better choice in this situation,
so I'll reroll and fix the other issues mentioned.
-- 
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | https://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: https://keybase.io/bk2204