From: Jonathan Nieder <jrnieder@gmail.com>
Date: Thu, 23 Mar 2017 22:36:21 GMT
Subject: Re: [PATCH 1/7] submodule.c: use argv_array in is_submodule_modified
Message-ID: <20170323223621.GC20794@aiede.mtv.corp.google.com>
In-Reply-To: <20170323223338.32274-2-sbeller@google.com>

Stefan Beller wrote:

> struct argv_array is easier to use and maintain

Yes!

[...]
>  submodule.c | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)

I also like the diffstat. :)

[...]
> --- a/submodule.c
> +++ b/submodule.c
> @@ -1043,12 +1043,6 @@ unsigned is_submodule_modified(const char *path, int ignore_untracked)
>  {
>  	ssize_t len;
>  	struct child_process cp = CHILD_PROCESS_INIT;
> -	const char *argv[] = {
> -		"status",
> -		"--porcelain",
> -		NULL,
> -		NULL,
> -	};

and the avoidance of this kind of fixed-size magic.

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Thank you.