From: Jeff King <peff@peff.net>
Date: Thu, 23 Mar 2017 18:24:15 GMT
Subject: Re: [PATCH] sequencer: fix missing newline
Message-ID: <20170323182414.n7qgw7x4qibkg72z@sigill.intra.peff.net>
In-Reply-To: <20170323182221.i3noikxpmrn4ymi4@sigill.intra.peff.net>

On Thu, Mar 23, 2017 at 02:22:21PM -0400, Jeff King wrote:

> > > > When using rebase --interactive where one of the lines is marked as
> > > > 'edit' this is the resulting output:
> > > > 
> > > >     Stopped at ec3b9c4...  stuffYou can amend the commit now, with
> > > 
> > > Ugh, I should have caught this. The warning() call implicitly adds a
> > > newline, the fprintf() doesn't.
> > > 
> > > Patch is obviously good.
> > 
> > All good.  If we're keeping score for finding each others bugs, I still
> > think you're winning :)
> 
> It's my bug, actually. Brown paper bag, anyone?

The most embarrassing part is that I've been running with this for days
and didn't notice. I guess I just gloss over the hint text.

-Peff