From: Jeff King Date: Wed, 22 Mar 2017 21:41:39 GMT Subject: Re: [PATCH v2 1/3] stash: don't show internal implementation details Message-ID: <20170322214139.3nqxdzfxar5nqawo@sigill.intra.peff.net> In-Reply-To: <20170322213347.GF27158@hank> On Wed, Mar 22, 2017 at 09:33:47PM +0000, Thomas Gummerer wrote: > > > - sed -e 1,2d >actual && # drop "Saved..." and "HEAD is now..." > > > + sed -e 1,1d >actual && # drop "Saved..." > > > test_i18ncmp expect actual > > > ' > > > > This too, though I think "1d" would be the more usual way to say it. > > Right thanks, I'll keep that in mind for another time. (I guess just > changing this doesn't warrant a re-roll?) Nah, I don't think it's important enough (and I give even odds that Junio may just tweak it while applying). -Peff