From: Jeff King <peff@peff.net>
Date: Wed, 22 Mar 2017 13:06:15 GMT
Subject: Re: [PATCH 18/20] commit_packed_refs(): use reference iteration
Message-ID: <20170322130615.hcl5vrezkcr45fdk@sigill.intra.peff.net>
In-Reply-To: <b49b4ae0-bcef-ce1d-62d5-f76a11e84766@alum.mit.edu>

On Wed, Mar 22, 2017 at 09:42:58AM +0100, Michael Haggerty wrote:

> > Should we be checking that peel_error is only PEELED or NON_TAG?
> 
> This is a good question, and it took me a while to figure out the whole
> answer. At first I deleted this check without much thought because it
> was just an internal consistency check that should never trigger. But
> actually the story is more complicated than that.
> 
> Tl;dr: the old code is slightly wrong and I think the new code is correct.

OK, that all makes sense. Thanks for digging.

-Peff