From: Jeff King Date: Tue, 21 Mar 2017 22:19:59 GMT Subject: Re: [PATCH v2 2/3] stash: pass the pathspec argument to git reset Message-ID: <20170321221959.dtkz2i33jyojwzca@sigill.intra.peff.net> In-Reply-To: <20170321221219.28041-3-t.gummerer@gmail.com> On Tue, Mar 21, 2017 at 10:12:18PM +0000, Thomas Gummerer wrote: > For "git stash -p --no-keep-index", the pathspec argument is currently > not passed to "git reset". This means that changes that are staged but > that are excluded from the pathspec still get unstaged by git stash -p. > > Make sure that doesn't happen by passing the pathspec argument to the > git reset in question, bringing the behaviour in line with "git stash -- > ". > > Signed-off-by: Thomas Gummerer > --- > git-stash.sh | 2 +- > t/t3904-stash-patch.sh | 8 ++++++++ > 2 files changed, 9 insertions(+), 1 deletion(-) This one looks good to me. -Peff