From: Jeff King <peff@peff.net>
Date: Mon, 20 Mar 2017 17:51:46 GMT
Subject: Re: [PATCH 11/20] refs: record the ref_store in ref_cache, not ref_dir
Message-ID: <20170320175145.zwfqp7varl4hwink@sigill.intra.peff.net>
In-Reply-To: <745f1ed3781083f99da31a33dec08f03bffa7d4f.1490026594.git.mhagger@alum.mit.edu>

On Mon, Mar 20, 2017 at 05:33:16PM +0100, Michael Haggerty wrote:

> Instead of keeping a pointer to the ref_store in every ref_dir entry,
> store it once in `struct ref_cache`, and change `struct ref_dir` to
> include a pointer to its containing `ref_cache` instead. This makes it
> easier to add to the information that is stored in `struct ref_cache`
> without inflating the size of the individual entries.

This last sentence confused me. It's a pointer either way, no?

Do you just mean that we are free to add whatever we like to the
"ref_cache" without polluting the "ref_store" that is a more public data
structure?

-Peff