From: Thomas Gummerer Date: Sun, 19 Mar 2017 20:23:48 GMT Subject: Re: [BUG] "git stash -- path" reports wrong unstaged changes Message-ID: <20170319202351.8825-1-t.gummerer@gmail.com> In-Reply-To: <20170318183658.GC27158@hank> This series implements my proposal for fixing bug in git stash -- , plus the two other things I noticed while looking at the code. > I think one option would be to to just keep quiet about the exact > changes that git stash push makes, similar to what we do in the > --include-untracked and in the -p case. The other option would be to > find the files that are affected and print them, but that would > probably be a bit too noisy especially in cases such as > git stash push -- docs/*. 1/3 implements just this. This may deserve some more discussion on what should actually be done. > Also from reading the code in the -p case, when --keep-index is given, > the git reset there doesn't respect $GIT_QUIET at all, and also > doesn't respect the pathspec argument, which seems like another bug. > I can submit a patch series for those, but I won't get to it before > tomorrow :) 2/3 and 3/3 have the fixes for the above. No tests yet, as I'm not 100% sure 3/3 is doing the right thing, though I think it makes the overall experience better. Thomas Gummerer (3): stash: show less information for stash push -- stash: make push -p -q --no-keep-index quiet stash: pass the pathspec argument to git reset git-stash.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.12.0.483.gad4152297