From: Brandon Williams <bmwill@google.com>
Date: Fri, 17 Mar 2017 19:08:56 GMT
Subject: Re: [PATCH v3 2/5] setup: allow for prefix to be passed to git commands
Message-ID: <20170317190856.GC110341@google.com>
In-Reply-To: <CAGZ79kZAZeb5rsL80dty_tRM5SDCAXVq_yATpDQREq_vV4Yj+Q@mail.gmail.com>

On 03/17, Stefan Beller wrote:
> >         prefix = setup_git_directory_gently_1(nongit_ok);
> > +       env_prefix = getenv(GIT_TOPLEVEL_PREFIX_ENVIRONMENT);
> > +
> > +       if (env_prefix)
> > +               prefix = env_prefix;
> > +
> >         if (prefix)
> >                 setenv(GIT_PREFIX_ENVIRONMENT, prefix, 1);
> 
> so we load that GIT_TOPLEVEL_PREFIX_ENVIRONMENT prefix
> first, such that we essentially copy it into GIT_PREFIX_ENVIRONMENT,
> such that e.g. aliased commands will know about the superprefix, too.

I don't follow, this doesn't have anything to do with super-prefix.

> 
> ok, sounds reasonable to me; though I do not use this feature,
> so my judgement is not as good.
> 
> Do we need a test for this behavior?
> 
> Thanks,
> Stefan

-- 
Brandon Williams