From: Brandon Williams <bmwill@google.com>
Date: Fri, 17 Mar 2017 06:58:23 GMT
Subject: Re: [PATCH v4 03/10] submodule sync: skip work for inactive submodules
Message-ID: <20170317065823.GA101452@google.com>
In-Reply-To: <xmqq8to4a2xv.fsf@gitster.mtv.corp.google.com>

On 03/16, Junio C Hamano wrote:
> Stefan Beller <sbeller@google.com> writes:
> 
> > On Thu, Mar 16, 2017 at 3:29 PM, Brandon Williams <bmwill@google.com> wrote:
> >> Sync does some work determining what URLs should be used for a submodule
> >> but then throws this work away if the submodule isn't active.  Instead
> >> perform the activity check earlier and skip inactive submodule in order
> >> to avoid doing unnecessary work.
> >>
> >> Signed-off-by: Brandon Williams <bmwill@google.com>
> >> ---
> >
> >> +               # skip inactive submodules
> >> +               if ! git config "submodule.$name.url" >/dev/null 2>/dev/null
> 
> Just a style thing, but ">/dev/null 2>&1" is probably shorter and
> more idiomatic.
> 

Yeah you're right.  I was just moving around the code that was already
there.  But this line is removed in the next patch anyways so it
probably doesn't matter much.

-- 
Brandon Williams