From: Eric Wong Date: Sat, 04 Mar 2017 06:55:48 GMT Subject: Re: [PATCH] http: inform about alternates-as-redirects behavior Message-ID: <20170304065548.GA20734@whir> In-Reply-To: <20170304031314.32bta4prahf7pfp7@sigill.intra.peff.net> Jeff King wrote: > The warning itself: > > > + warning("alternate disabled by http.followRedirects!=true: %s", > > feels like it could use some whitespace around the "!=", but maybe > that's just me. Yeah, I kinda wanted to emulate the command-line syntax. Maybe rewording it a bit and showing how to enable it will make more sense: warning("alternate: %s", url); warning(" may be enabled by -c http.followRedirects=true"); As well as keeping individual lines shorter and hopefully easier-to-read.