From: Jeff King <peff@peff.net>
Date: Fri, 03 Mar 2017 04:46:30 GMT
Subject: Re: [PATCH v2 5/9] Make read_early_config() reusable
Message-ID: <20170303044630.tfogzhzbokuoiwh6@sigill.intra.peff.net>
In-Reply-To: <64135c6df520c1ca6a6e667855ac03c14d2dd153.1488506615.git.johannes.schindelin@gmx.de>

On Fri, Mar 03, 2017 at 03:04:20AM +0100, Johannes Schindelin wrote:

> The pager configuration needs to be read early, possibly before
> discovering any .git/ directory.
> 
> Let's not hide this function in pager.c, but make it available to other
> callers.
> [...]
> +	 * Note that this is a really dirty hack that does the wrong thing in
> +	 * many cases. The crux of the problem is that we cannot run

Makes sense. I'll assume the words "dirty hack" disappear from this
now-public function as you fix it up in a future patch. :)

-Peff