From: Jeff King <peff@peff.net>
Date: Mon, 27 Feb 2017 09:31:22 GMT
Subject: Re: [PATCH] interpret_branch_name(): handle auto-namelen for @{-1}
Message-ID: <20170227093122.3jdb2b62hlbbio5r@sigill.intra.peff.net>
In-Reply-To: <20170227092540.ob2oy4qpgfukqwtc@sigill.intra.peff.net>

On Mon, Feb 27, 2017 at 04:25:40AM -0500, Jeff King wrote:

> However, before we do that auto-namelen magic, we call
> interpret_nth_prior_checkout(), which gets fed the bogus
> "0". This was broken by 8cd4249c4 (interpret_branch_name:
> always respect "namelen" parameter, 2014-01-15).  Though to
> be fair to that commit, it was broken in the _opposite_
> direction before, where we would always treat "name" as a
> string even if a length was passed.

That commit is mine, by the way. More embarrassing than introducing the
bug is that I _noticed_ the problem at the time and wrote a paragraph in
the commit message rationalizing why it was OK, rather than just doing
this trivial fix.

-Peff