From: Jeff King Date: Tue, 21 Feb 2017 17:50:21 GMT Subject: Re: [PATCH v2] config: preserve case for one-shot config on the command line Message-ID: <20170221175021.znvpfvnlfjh4jsrf@sigill.intra.peff.net> In-Reply-To: On Tue, Feb 21, 2017 at 09:17:07AM -0800, Junio C Hamano wrote: > * Changes from v1: > > - update the comment before the second loop to find the last > dot. > > - move two new tests into existing t1300 (at least for now). > > - make it clear that the second of the new tests check two > aspects of "three level vars" by setting up the expectation for > the first half near the actual tests and adding comments on > what it tests before the second half. Thanks, this addresses all of my (admittedly minor) concerns. -Peff