From: Jeff King <peff@peff.net>
Date: Fri, 17 Feb 2017 23:41:28 GMT
Subject: Re: [PATCH 2/3] update-ref: pass reflog message argument to delete_refs
Message-ID: <20170217234128.d7uhxu4fjzsc4yjh@sigill.intra.peff.net>
In-Reply-To: <8737fcqtcj.fsf@kyleam.com>

On Fri, Feb 17, 2017 at 06:40:28PM -0500, Kyle Meyer wrote:

> > For reference, the two things I notice are:
> >
> >   - we prefer test_path_is_missing to "! test -f" these days.
> >
> >   - we don't redirect the output of grep (it's handled already in
> >     non-verbose mode, and in verbose mode we try to be...verbose).
> 
> Would moving cleanup like "rm -f .git/$m" within the test's body using
> test_when_finished also be preferred?

Yeah, that too.  I forgot to mention it.

-Peff