From: Jeff King Date: Tue, 14 Feb 2017 06:16:07 GMT Subject: Re: [PATCH v2] remote helpers: avoid blind fall-back to ".git" when setting GIT_DIR Message-ID: <20170214061607.qyucfue335aqgji2@sigill.intra.peff.net> In-Reply-To: <20161230004845.rknafqsyosmyr6z2@sigill.intra.peff.net> On Thu, Dec 29, 2016 at 07:48:45PM -0500, Jeff King wrote: > On Thu, Dec 29, 2016 at 04:11:14PM -0800, Jonathan Nieder wrote: > > > Thanks. Here's the patch again, now with commit messages and a test. > > Thanks for the analysis and sorry for the slow turnaround. > > Thanks for following up. While working on a similar one recently, I had > the nagging feeling that there was a case we had found that was still to > be dealt with, and I think this was it. :) > > The patch to the C code looks good. I have a few comments on the tests: I happened to run into this problem myself today, so I thought I'd prod you. I think your patch looks good. Hopefully I didn't scare you off with my comments. :) -Peff