From: Siddharth Kannan Date: Tue, 14 Feb 2017 04:23:29 GMT Subject: Re: [PATCH 1/2 v3] revision.c: args starting with "-" might be a revision Message-ID: <20170214042329.GA24543@ubuntu-512mb-blr1-01.localdomain> In-Reply-To: Hey Junio, > > See the 3-patch series I just sent out. I didn't think it through > very carefully (especially the error message the other caller > produces), but the whole thing _smells_ correct to me. Okay, got it! I will write-up those changes, and make sure nothing bad happens. (Also, the one other function that calls handle_revision_opt, parse_revision_opt needs to be fixed for any changes in handle_revision_opt.) I will do all of this in the next week (Unfortunately, exams!) and submit a new version of this patch (Also, I need to update tests, add documentation, and remove code that does this shorthand stuff for other commands as per Matthieu's comments) -- Best Regards, Siddharth Kannan.