From: Jeff King <peff@peff.net>
Date: Tue, 24 Jan 2017 02:12:20 GMT
Subject: Re: [PATCH 0/12] reducing resource usage of for_each_alternate_ref
Message-ID: <20170124021220.6xgdcfa4a3punlt4@sigill.intra.peff.net>
In-Reply-To: <20170124013341.GA185930@google.com>

On Mon, Jan 23, 2017 at 05:33:41PM -0800, Brandon Williams wrote:

> On 01/23, Jeff King wrote:
> > 
> > A brief overview of the patches:
> > 
> >   [01/12]: for_each_alternate_ref: handle failure from real_pathdup()
> >   [02/12]: for_each_alternate_ref: stop trimming trailing slashes
> >   [03/12]: for_each_alternate_ref: use strbuf for path allocation
> > 
> >     Bugfixes and cleanups (the first one is actually a recent-ish
> >     regression).
> 
> Which is most likely my fault, Sorry! :)
> 
> I think the old behavior was to die and not return NULL.

Yes, it is. :)

But I think it's probably pretty hard to trigger in practice. And on the
plus side, I think the new behavior after my patch is much more sensible
than even the original.

-Peff