From: Jeff King <peff@peff.net>
Date: Mon, 23 Jan 2017 23:54:45 GMT
Subject: Re: [PATCH v2 0/5] string-list: make string_list_sort() reentrant
Message-ID: <20170123235445.qsejumltutd2vrhd@sigill.intra.peff.net>
In-Reply-To: <67ac53cd-3fc0-8bd0-30f4-129281c3090f@web.de>

On Sun, Jan 22, 2017 at 06:47:18PM +0100, René Scharfe wrote:

> Use qsort_s() from C11 Annex K to make string_list_sort() safer, in
> particular when called from parallel threads.
> 
> Changes from v1:
> * Renamed HAVE_QSORT_S to HAVE_ISO_QSORT_S in Makefile to disambiguate.
> * Added basic perf test (patch 3).
> * Converted a second caller to QSORT_S, in ref-filter.c (patch 5).

This looks nicely done overall, and I appreciate the perf test.

The speed looks like a reasonable outcome. I'm torn on the qsort_r()
demo patch. I don't think it looks too bad. OTOH, I don't think I would
want to deal with the opposite-argument-order versions.

Is there any interest in people adding the ISO qsort_s() to their libc
implementations? It seems like it's been a fair number of years by now.

-Peff