From: Jeff King <peff@peff.net>
Date: Tue, 17 Jan 2017 15:35:07 GMT
Subject: Re: [PATCH v5 7/7] t/t7004-tag: Add --format specifier tests
Message-ID: <20170117153507.vr3i6k5hl3whjorf@sigill.intra.peff.net>
In-Reply-To: <20170115184705.10376-8-santiago@nyu.edu>

On Sun, Jan 15, 2017 at 01:47:05PM -0500, santiago@nyu.edu wrote:

> From: Santiago Torres <santiago@nyu.edu>
> 
> tag -v now supports --format specifiers to inspect the contents of a tag
> upon verification. Add two tests to ensure this behavior is respected in
> future changes.
> 
> Signed-off-by: Santiago Torres <santiago@nyu.edu>
> ---
>  t/t7004-tag.sh | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/t/t7004-tag.sh b/t/t7004-tag.sh
> index 07869b0c0..b2b81f203 100755
> --- a/t/t7004-tag.sh
> +++ b/t/t7004-tag.sh
> @@ -874,6 +874,22 @@ test_expect_success GPG 'verifying a forged tag should fail' '
>  	test_must_fail git tag -v forged-tag
>  '
>  
> +test_expect_success 'verifying a proper tag with --format pass and format accordingly' '
> +	cat >expect <<-\EOF 

Trailing whitespace after "EOF" here (and below). Otherwise the tests
look reasonable to me.

-Peff