From: Brandon Williams Date: Thu, 12 Jan 2017 23:53:31 GMT Subject: [PATCH 04/27] attr.c: explain the lack of attr-name syntax check in parse_attr() Message-ID: <20170112235354.153403-5-bmwill@google.com> In-Reply-To: <20170112235354.153403-1-bmwill@google.com> From: Junio C Hamano Signed-off-by: Junio C Hamano Signed-off-by: Stefan Beller Signed-off-by: Brandon Williams --- attr.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/attr.c b/attr.c index 007f1a299..6b55a57ef 100644 --- a/attr.c +++ b/attr.c @@ -183,6 +183,12 @@ static const char *parse_attr(const char *src, int lineno, const char *cp, return NULL; } } else { + /* + * As this function is always called twice, once with + * e == NULL in the first pass and then e != NULL in + * the second pass, no need for invalid_attr_name() + * check here. + */ if (*cp == '-' || *cp == '!') { e->setto = (*cp == '-') ? ATTR__FALSE : ATTR__UNSET; cp++; -- 2.11.0.390.gc69c2f50cf-goog