From: Jeff King Date: Sat, 07 Jan 2017 01:31:26 GMT Subject: Re: [PATCH] branch_get_push: do not segfault when HEAD is detached Message-ID: <20170107013126.4ub726mf73y36of3@sigill.intra.peff.net> In-Reply-To: <87bmvjll8m.fsf@kyleam.com> On Fri, Jan 06, 2017 at 08:19:53PM -0500, Kyle Meyer wrote: > > The other option is just "git checkout --detach", which is also used in > > the test suite. I tend to prefer it because it's a little more obvious > > to a reader. > > True, that does seem clearer. Seems I should've waited a bit before > sending out v2. I think it's OK either way. Junio can also mark it up while applying, too, if he has a preference. -Peff